Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'features/RefStructInterfaces' into 'main' #73567

Merged
merged 42 commits into from
May 18, 2024

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from jjonescz and cston May 17, 2024 22:36
@AlekseyTs AlekseyTs requested review from a team as code owners May 17, 2024 22:36
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label May 17, 2024
@AlekseyTs AlekseyTs enabled auto-merge May 17, 2024 22:51
@AlekseyTs AlekseyTs merged commit 07d428b into dotnet:main May 18, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 18, 2024
ToddGrun added a commit that referenced this pull request May 21, 2024
The method extraction code uses ITypeParameterSymbol's constraints to generate the new method's text. This codepath had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType

This is in support of the "allows ref struct" on interfaces feature outlined here: #72124

This ref structs for interfaces feature was merged via this PR: #73567
ToddGrun added a commit to ToddGrun/roslyn that referenced this pull request May 21, 2024
The description building code for method constraints in the object browser had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType

This is in support of the "allows ref struct" on interfaces feature outlined here: dotnet#72124

This ref structs for interfaces feature was merged via this PR: dotnet#73567
ToddGrun added a commit to ToddGrun/roslyn that referenced this pull request May 22, 2024
The selected display part building code for method constraints in signature help had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType

This is in support of the "allows ref struct" on interfaces feature outlined here: dotnet#72124

This ref structs for interfaces feature was merged via this PR: dotnet#73567
ToddGrun added a commit that referenced this pull request May 22, 2024
* Add extract method support for ref struct interfaces

The method extraction code uses ITypeParameterSymbol's constraints to generate the new method's text. This codepath had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType

This is in support of the "allows ref struct" on interfaces feature outlined here: #72124

This ref structs for interfaces feature was merged via this PR: #73567
ToddGrun added a commit that referenced this pull request May 22, 2024
The selected display part building code for method constraints in signature help had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType

This is in support of the "allows ref struct" on interfaces feature outlined here: #72124

This ref structs for interfaces feature was merged via this PR: #73567
ToddGrun added a commit that referenced this pull request May 22, 2024
* Add object browser support for ref struct interfaces

The description building code for method constraints in the object browser had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType

This is in support of the "allows ref struct" on interfaces feature outlined here: #72124

This ref structs for interfaces feature was merged via this PR: #73567
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
BillWagner added a commit to BillWagner/docs that referenced this pull request Jul 30, 2024
The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
BillWagner added a commit to BillWagner/docs that referenced this pull request Jul 30, 2024
The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
BillWagner added a commit to BillWagner/docs that referenced this pull request Jul 31, 2024
The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
BillWagner added a commit to dotnet/docs that referenced this pull request Jul 31, 2024
…rfaces (#41948)

* Add, update messages in dotnet/roslyn#73567

The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.

* incorporate additional ref struct error conditions

* Edit pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers New Feature - RefStructInterfaces untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants