Add public API for ref like type parameters #73335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
jjonescz
reviewed
May 6, 2024
| @@ -27,6 +27,7 @@ internal class CodeGenerationTypeParameterSymbol( | |||
| public bool HasConstructorConstraint { get; } = hasConstructorConstraint; | |||
| public bool HasReferenceTypeConstraint { get; } = hasReferenceConstraint; | |||
| public bool HasValueTypeConstraint { get; } = hasValueConstraint; | |||
| public bool AllowsByRefLike => false; | |||
There was a problem hiding this comment.
I see CodeGenerationTypeParameterSymbol is used for example in IMethodSymbolExtensions.RenameTypeParameters - should we add a real bool allowsByRefLike parameter to support that?
There was a problem hiding this comment.
I see
CodeGenerationTypeParameterSymbolis used for example inIMethodSymbolExtensions.RenameTypeParameters- should we add a realbool allowsByRefLikeparameter to support that?
In general we are not required to adjust IDE code
cston
approved these changes
May 6, 2024
jjonescz
approved these changes
May 7, 2024
AlekseyTs
merged commit 319fc7c
into
dotnet:features/RefStructInterfaces
28 checks passed
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #73330.