Collection expressions: require Add method callable with a single argument for class and struct types that do not use [CollectionBuilder] #72796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument for class and struct types that do not use [CollectionBuilder] (dotnet#72654) Co-authored-by: AlekseyTs <[email protected]>
The main observable change - the original (unconverted) params arguments are used in the process of populating target collection. Spec changes: dotnet/csharplang#8022 Fixes dotnet#72098
…erge-CollectionAdd
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
AlekseyTs
approved these changes
Mar 29, 2024
|
cc @jaredpar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges
features/CollectionAddintorelease/dev17.10.Spec changes: dotnet/csharplang#8022
Fixes #72098