Fix code generation for records with semi-colon #48313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Oct 4, 2020
ghost
added this to the 
|
This will not make it into 16.8 where records are initially shipping. are we ok with this being in 16.9? |
333fred
added a commit
that referenced
this pull request
Oct 5, 2020
…features/interpolated-string-constants * upstream/master: (222 commits) Update dependencies from https://github.com/dotnet/roslyn build 20201004.1 (#48325) Fix code generation for records with semi-colon (#48313) More native integer tests (#48266) Add contract calls to help track down issue. Move code Fix bugs Update Nerdbank.Streams to 2.6.81 Reverts IServiceBroker changes (#48221) PR feedback Update Clashing Enum Members.md (#46816) Additional tests converting between native integers and 64-bit integers (#48229) Support checked and unchecked statements in formatting Add formatting tests with checked and unchecked Update src/EditorFeatures/CSharpTest/ConvertAutoPropertyToFullProperty/ConvertAutoPropertyToFullPropertyTests.cs Move and rename test. Add test Support feature when span is selected Update SG cookbook (#48182) Fix method consolidation Update buffer on UI thread ...
|
@jinujoseph @CyrusNajmabadi Do we want to port this fix to 16.8? |
|
Not especially. My "port to 16.8 bar" would be "bad crashes and other extremely serious issues". this is minor and easily solved by the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48295