Reverts IServiceBroker changes #48221

tmat · 2020-10-01T19:48:39Z

Fixes AB#1219902
Fixes AB#1223635
Fixes AB#1224230
Fixes AB#1202649
Fixes AB#1221938
Fixes AB#1223216

Reverts partially or in full the following commits:

e91ccb5: Use MessagePack for serialization, move services to IServiceBroker (Use MessagePack for serialization, move services to IServiceBroker #47461)
e0e3655: Provide required callback targets
1f7397e: Ensure IServiceBroker is used on a background thread
f60ff7e: Prevent potential deadlocks when reading/writing assets (Prevent potential deadlocks when reading/writing assets #47864)
ebb674f: Make sure to complete copy before returning
c020fe8: Wait for GetAssetsAsync before returning
24bcf13: Remove ClientDisconnectedSource
57759e3: Do not cancel operations after point of no return
4123b1c: Work around incorrect implementation of WithMultiplexingStream
9499caf: Fix steaming ISB service hang (Fix steaming ISB service hang #47669)
e53ffb7: Brokered services (Brokered services #47216)

sharwell · 2020-10-02T06:30:44Z

@tmat Can you update the first post to give a list of the pull requests which this change reverts?

sharwell · 2020-10-02T06:32:54Z

Also I'm seeing this in the integration test results (does not appear in the current release/dev16.8 branch):

tmat · 2020-10-02T06:41:55Z

I had to revert some commits only partially not to break TypeScript. I also left some test changes in (test output helpers).
Generally any commit that was adding/changing ISB/MessagePack code was reverted.

tmat · 2020-10-02T06:42:46Z

The logs for the failing integration tests show:

10/02/2020 05:23:19 Coordinated Universal Time : Error : System.Threading.Tasks.TaskCanceledException: A task was canceled. HResult='-2146233029' 
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.ServiceHub.Client.HubClient.RemoteServiceBrokerWrapper.<>c__DisplayClass9_0.<<RequestServiceChannelAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.ServiceHub.Utility.Shared.ServiceHubRetry.<ExecuteAsync>d__0`1.MoveNext()
10/02/2020 05:23:19 Coordinated Universal Time : Error : System.OperationCanceledException: The operation was canceled. HResult='-2146233029' 
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at Microsoft.ServiceHub.Utility.Shared.ServiceHubRetry.<ExecuteAsync>d__0`1.MoveNext()
10/02/2020 05:23:19 Coordinated Universal Time : Error : System.OperationCanceledException: The operation was canceled. HResult='-2146233029' 
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at Microsoft.ServiceHub.Utility.Shared.ServiceHubRetry.<ExecuteAsync>d__0`1.MoveNext()

10/02/2020 08:01:54 Coordinated Universal Time: Error : 1 :[ServiceHub.RoslynCodeAnalysisService:9212] Unexpected exception: System.IO.IOException: Pipe is broken.
   at System.IO.Pipes.PipeStream.CheckWriteOperations()
   at System.IO.Pipes.PipeStream.Write(Byte[] buffer, Int32 offset, Int32 count)
   at System.IO.BufferedStream.Flush()
   at System.IO.BufferedStream.Dispose(Boolean disposing)
   at System.IO.Stream.Close()
   at Microsoft.CodeAnalysis.Remote.RemoteEndPoint.<WriteDataToNamedPipeAsync>d__24`1.MoveNext() in /_/src/Workspaces/Remote/Core/RemoteEndPoint.cs:line 256
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.CodeAnalysisService.<>c__DisplayClass15_0.<<CalculateDiagnosticsAsync>b__0>d.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Services/CodeAnalysis/CodeAnalysisService_Diagnostics.cs:line 47
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.ServiceBase.<RunServiceAsync>d__17.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Services/ServiceBase.cs:line 127

and

10/02/2020 05:55:58 Coordinated Universal Time: Error : 1 :[devenv:10216] Unexpected exception: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Concurrent.ConcurrentDictionary`2.get_Item(TKey key)
   at Microsoft.CodeAnalysis.Remote.SolutionAssetStorage.<GetAssetAsync>d__4.MoveNext() in /_/src/Workspaces/Remote/Core/SolutionAssetStorage.cs:line 67
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.RemoteHostAssetSerialization.<WriteDataAsync>d__0.MoveNext() in /_/src/Workspaces/Remote/Core/RemoteHostAssetSerialization.cs:line 35
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.RemoteEndPoint.<>c__DisplayClass23_0`1.<<WriteDataToNamedPipeAsync>b__0>d.MoveNext() in /_/src/Workspaces/Remote/Core/RemoteEndPoint.cs:line 227
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.RemoteEndPoint.<WriteDataToNamedPipeAsync>d__24`1.MoveNext() in /_/src/Workspaces/Remote/Core/RemoteEndPoint.cs:line 255
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.ServiceHubRemoteHostClient.<GetAssetsAsync>d__19.MoveNext() in /_/src/Workspaces/Remote/Core/ServiceHubRemoteHostClient.cs:line 189

I have seen these kind of errors before ISB change went in as well.

jinujoseph · 2020-10-02T19:48:56Z

Approved to merge post review

ghost · 2020-10-02T20:13:54Z

Hello @Cosifne!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost

Auto-approval

…features/interpolated-string-constants * upstream/master: (222 commits) Update dependencies from https://github.com/dotnet/roslyn build 20201004.1 (#48325) Fix code generation for records with semi-colon (#48313) More native integer tests (#48266) Add contract calls to help track down issue. Move code Fix bugs Update Nerdbank.Streams to 2.6.81 Reverts IServiceBroker changes (#48221) PR feedback Update Clashing Enum Members.md (#46816) Additional tests converting between native integers and 64-bit integers (#48229) Support checked and unchecked statements in formatting Add formatting tests with checked and unchecked Update src/EditorFeatures/CSharpTest/ConvertAutoPropertyToFullProperty/ConvertAutoPropertyToFullPropertyTests.cs Move and rename test. Add test Support feature when span is selected Update SG cookbook (#48182) Fix method consolidation Update buffer on UI thread ...

tmat added 2 commits October 1, 2020 17:23

Revert ISB services

fe91a74

Fix TFM

8a41999

tmat force-pushed the Reverts branch from e6a57e3 to 42c3137 Compare October 2, 2020 01:11

Revert ISB services 2

b294776

tmat force-pushed the Reverts branch from 42c3137 to b294776 Compare October 2, 2020 01:21

tmat added 2 commits October 1, 2020 19:50

Fix formatting

2693c8c

Fix

fe67114

tmat marked this pull request as ready for review October 2, 2020 05:15

tmat requested review from a team as code owners October 2, 2020 05:15

tmat added this to the 16.8.P4 milestone Oct 2, 2020

tmat mentioned this pull request Oct 2, 2020

Reverts vs deps2 #48232

Closed

jinujoseph added Area-IDE Approved to merge labels Oct 2, 2020

CyrusNajmabadi approved these changes Oct 2, 2020

View reviewed changes

Cosifne added the auto-merge label Oct 2, 2020

ghost approved these changes Oct 2, 2020

View reviewed changes

Cosifne removed the auto-merge label Oct 2, 2020

jaredpar merged commit 1e606ed into dotnet:release/dev16.8 Oct 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reverts IServiceBroker changes #48221

Reverts IServiceBroker changes #48221

tmat commented Oct 1, 2020 •

edited

Loading

sharwell commented Oct 2, 2020

sharwell commented Oct 2, 2020

tmat commented Oct 2, 2020 •

edited

Loading

tmat commented Oct 2, 2020 •

edited

Loading

jinujoseph commented Oct 2, 2020

ghost commented Oct 2, 2020

ghost left a comment

Reverts IServiceBroker changes #48221

Reverts IServiceBroker changes #48221

Conversation

tmat commented Oct 1, 2020 • edited Loading

sharwell commented Oct 2, 2020

sharwell commented Oct 2, 2020

tmat commented Oct 2, 2020 • edited Loading

tmat commented Oct 2, 2020 • edited Loading

jinujoseph commented Oct 2, 2020

ghost commented Oct 2, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost left a comment

Choose a reason for hiding this comment

tmat commented Oct 1, 2020 •

edited

Loading

tmat commented Oct 2, 2020 •

edited

Loading

tmat commented Oct 2, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.