4.x: Fix ActivePlan crashing with self-joins #514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash due to key reuse in
ActivePlan
that prevents self-joins such as this:Without the fix, there is a crash:
Note that I have generally little understanding of the Join Patterns so I'm not sure if this fix is actually legitimate in the context of the intended behavior of the Join Patterns beyond the fact that existing unit tests pass with the modification (locally).