4.x: Fix ActivePlan crashing with self-joins

dotnet · May 17, 2018 · 636ff38 · 636ff38
1 parent 269d926
commit 636ff38
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/Rx.NET/Source/src/System.Reactive/Joins/ActivePlan.cs b/Rx.NET/Source/src/System.Reactive/Joins/ActivePlan.cs
@@ -14,7 +14,10 @@ internal abstract class ActivePlan
 
         protected void AddJoinObserver(IJoinObserver joinObserver)
         {
-            joinObservers.Add(joinObserver, joinObserver);
+            if (!joinObservers.ContainsKey(joinObserver))
+            {
+                joinObservers.Add(joinObserver, joinObserver);
+            }
         }
 
         protected void Dequeue()
@@ -1432,4 +1435,4 @@ internal override void Match()
             }
         }
     }
-}
+}
diff --git a/Rx.NET/Source/tests/Tests.System.Reactive/Tests/Linq/ObservableJoinsTest.cs b/Rx.NET/Source/tests/Tests.System.Reactive/Tests/Linq/ObservableJoinsTest.cs
@@ -1697,5 +1697,16 @@ private IEnumerable<Plan<int>> GetPlans(Exception ex)
         }
 
         #endregion
+
+        [Fact]
+        public void SameSource()
+        {
+            var source = Observable.Range(1, 5);
+
+            var list = Observable.When(source.And(source).Then((a, b) => a + b))
+                .ToList().First();
+
+            Assert.Equal(new List<int>() { 2, 4, 6, 8, 10 }, list);
+        }
     }
-}
+}