Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Add pseudo console APIs #479

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Add pseudo console APIs #479

merged 1 commit into from
Jul 3, 2020

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Jul 2, 2020

Closes #430

@AArnott AArnott self-assigned this Jul 2, 2020
@AArnott
Copy link
Collaborator Author

AArnott commented Jul 2, 2020

@ZoeyR do you want to review this?
I'm still using SafeObjectHandle instead of SafeFileHandle because we still target netstandard1.1 (which goes away in #476). I may be able to "get this right" if that PR completes soon.

@AArnott AArnott force-pushed the fix430 branch 2 times, most recently from d56f697 to 798afc4 Compare July 2, 2020 05:20
@ZoeyR
Copy link

ZoeyR commented Jul 2, 2020

Probably best to also have @zadjii-msft or @DHowett take a look as well.

@AArnott
Copy link
Collaborator Author

AArnott commented Jul 2, 2020

If it's not too hard, we can add unit tests for these p/invoke methods as well.

DHowett
DHowett approved these changes Jul 2, 2020
View reviewed changes
Copy link

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good and correct mechanical translation of these APIs. Thanks!

@AArnott AArnott merged commit 33a7da6 into master Jul 3, 2020
@AArnott AArnott deleted the fix430 branch July 3, 2020 00:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DHowett DHowett DHowett approved these changes

Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pseudo console api
3 participants
@AArnott @ZoeyR @DHowett