Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Drop .NET 2.0, netstandard1.1 support #476

Merged
merged 5 commits into from
Jul 4, 2020
Merged

Drop .NET 2.0, netstandard1.1 support #476

merged 5 commits into from
Jul 4, 2020

Conversation

qmfrederik
Copy link
Contributor

@qmfrederik qmfrederik commented Jul 1, 2020

Works toward #435

@qmfrederik qmfrederik marked this pull request as draft July 1, 2020 16:21
@qmfrederik
Copy link
Contributor Author

Looks like there's a build failure on uap10.0. I don't know much about UAP.
I kept net45 for now as I have a customer which is still on that platform 😄 .

@AArnott
Copy link
Collaborator

AArnott commented Jul 1, 2020

It looks more to me like cabinet.csproj is causing the problem in the build. Is it targeting netstandard1.3?

D:\a\1\s\src\Cabinet\Cabinet.csproj : error NU1201: Project CodeGenerationAttributes is not compatible with netstandard1.3 (.NETStandard,Version=v1.3). Project CodeGenerationAttributes supports: [D:\a\1\s\src\PInvoke.sln]
D:\a\1\s\src\Cabinet\Cabinet.csproj : error NU1201:   - net45 (.NETFramework,Version=v4.5) [D:\a\1\s\src\PInvoke.sln]
D:\a\1\s\src\Cabinet\Cabinet.csproj : error NU1201:   - netstandard2.0 (.NETStandard,Version=v2.0) [D:\a\1\s\src\PInvoke.sln]
D:\a\1\s\src\Cabinet\Cabinet.csproj : error NU1201:   - uap10.0 (UAP,Version=v10.0) [D:\a\1\s\src\PInvoke.sln]

@AArnott AArnott mentioned this pull request Jul 2, 2020
@qmfrederik qmfrederik marked this pull request as ready for review July 3, 2020 09:55
@AArnott AArnott merged commit b8c900b into dotnet:master Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants