Retire change wave 17.4 #9543
Closed
Retire change wave 17.4 #9543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its time has come, per the documented schedule.
|
Question for @baronfel and @marcpopMSFT: does the newer "try to stack breaking changes on .NET Core releases" policy imply that we should instead require all stale changewaves in the |
|
You mean basically retire the change waves once a year in November instead of every 6 months? I guess retiring a change wave is breaking so maybe that makes sense? Would we retire two waves each year? |
rokonec
approved these changes
Dec 18, 2023
ladipro
approved these changes
Dec 19, 2023
Comment on lines
-462
to
-464
| MSBuildEventSource.Log.SdkResolverServiceInitializeStart(); | ||
| _resolversList = _sdkResolverLoader.LoadAllResolvers(location); | ||
| MSBuildEventSource.Log.SdkResolverServiceInitializeStop(_resolversList.Count); |
There was a problem hiding this comment.
nit: LoadAllResolvers is now unused in product code and so are the two event source calls. It looks like LoadResolversFromManifest and LoadResolvers become transitively dead as well.
Forgind
approved these changes
Dec 21, 2023
|
Closing to wait for 9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its time has come, per the documented schedule.