Retire stale changewaves

[rainersigwald]

After discussion in #9543 we decided to delay changewave retirement to a release corresponding with 9.0.100. The time is now.

[rainersigwald]

Pinging folks relevant to the changes that are being made permanent: @AR-May, @JanKrivanek, @Forgind, @JaynieBai.

Also @marcpopMSFT as a heads up.

[Forgind]

I don't think this is actually necessary, but the example in ChangeWaves-Dev.md uses Wave17_4; we could update that to 17_12 or something.

Also, I thought we were planning to always have three change waves active at a time? If we're changing that, perhaps we should update the .md to say that 🙂

Finally, I have no idea why, but apparently this is a thing?

msbuild/src/Build/Resources/Strings.resx

Line 1301 in a49bf6c

<data name="PropertyOutsidePropertyGroupInTarget" xml:space="preserve" Condition="$([MSBuild]::AreFeaturesEnabled('17.6'))">

[JanKrivanek]

Overall looks good.
Before signing off it'd be nice to know more details about code being removed that's not part of changewaves condition on a first look (I know big portion of that is just port from the previous PR - but I didn't see the context there either)

[rainersigwald]

Also, I thought we were planning to always have three change waves active at a time? If we're changing that, perhaps we should update the .md to say that 🙂

I interpreted

A wave of features is set to "rotate out" (i.e. become standard functionality) two bands after its release. For example, wave 16.8 stayed opt-out through wave 16.10, becoming standard functionality when wave 17.0 is introduced.

and

Invalid Value (Ex: 16.9 when valid waves are 16.8 and 16.10)

To mean we should generally only have two available but I couldn't remember the details on this part. @marcpopMSFT do you, by chance?

[Forgind]

Also, I thought we were planning to always have three change waves active at a time? If we're changing that, perhaps we should update the .md to say that 🙂

I interpreted

A wave of features is set to "rotate out" (i.e. become standard functionality) two bands after its release. For example, wave 16.8 stayed opt-out through wave 16.10, becoming standard functionality when wave 17.0 is introduced.

and

Invalid Value (Ex: 16.9 when valid waves are 16.8 and 16.10)

To mean we should generally only have two available but I couldn't remember the details on this part. @marcpopMSFT do you, by chance?

It seems a bit ambiguous. I saw examples like this:

msbuild/documentation/wiki/ChangeWaves-Dev.md

Line 38 in 6fdd731

public static readonly Version[] AllWaves = { Wave17_0, Wave17_2, Wave17_4 };

which has three active change waves after the update. I interpreted two bands after its release to mean that we'd have 17_0 and 17_2 would be released (and active), and 17_4 would be active but not released (because it's in preview). Then when 17_4 releases, 17_0 would rotate out, and 17_6 would become the new preview version.

Regardless, I don't think it actually matters, so I have no problem with your interpretation and making that the official version.

[rainersigwald]

Ah; I think that makes sense in e.g. the 17.3 release--but now we're in the 17.12 release so that one will be "released and active", right?

[JanKrivanek]

Let's slash that code

[Forgind]

Ah; I think that makes sense in e.g. the 17.3 release--but now we're in the 17.12 release so that one will be "released and active", right?

I'd say we're working on 17.12, so it's active but still in preview, that is, not released.