Revert PR #23052 behavior under new app context switch #25613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validatedBehavior app context switch
PureWeen
requested review from
Eilon and
StephaneDelcroix
and removed request for
a team
Redth
approved these changes
Oct 31, 2024
|
/backport to release/8.0.1xx-sr10 |
|
Started backporting to release/8.0.1xx-sr10: https://github.com/dotnet/maui/actions/runs/11671545378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
PR #23052 introduced some new behavior with unforeseen performance implications (reported in #24551 and #25264). It was included in a servicing release and it's currently blocking us from moving to the latest servicing update. While we already have PRs to rectify the situation (#24823, or alternatively #25291) they are quite intrusive and thus not suitable for servicing.
This leaves us with very few options. I suggest conditionally reverting the changes from #23052 under an
Microsoft.Maui.RuntimeFeature.UseLegacyMeasureInvalidatedBehaviorapp context switch. This should allow us to optionally restore the .NET 8.0.82 behavior until a proper fix is in place.