Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Add ImageSource as LogicalChildren of MenuItem #24688

Merged
merged 3 commits into from
Sep 13, 2024
Merged

[C] Add ImageSource as LogicalChildren of MenuItem #24688

merged 3 commits into from
Sep 13, 2024

Conversation

StephaneDelcroix
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix commented Sep 10, 2024 •
edited
Loading

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner September 10, 2024 09:37
@StephaneDelcroix
Copy link
Contributor Author

I wonder if this fix wouldn't be sufficient for #23343...

@StephaneDelcroix StephaneDelcroix mentioned this pull request Sep 10, 2024
Closed
@mattleibow mattleibow added the area-xaml XAML, CSS, Triggers, Behaviors label Sep 10, 2024
@rmarinho rmarinho merged commit abec5a8 into main Sep 13, 2024
93 of 97 checks passed
@rmarinho rmarinho deleted the fix_20508 branch September 13, 2024 10:35
@kubaflo
Copy link
Contributor

kubaflo commented Sep 13, 2024 •
edited
Loading

What about this?
#23343 (comment)
This pr only partly fixes this bug: #23201

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-10.at.17.12.46.mp4

@kubaflo kubaflo mentioned this pull request Sep 14, 2024
Open
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Sep 20, 2024
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 fixed-in-net8.0-nightly This may be available in a nightly release! and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@mattleibow mattleibow mattleibow approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers left review comments

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-9.0.0-rc.2.24503.2 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
None yet
Milestone
No milestone
6 participants
@StephaneDelcroix @kubaflo @jonathanpeppers @mattleibow @rmarinho @samhouts