Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolbarItem font icon color not updating with AppThemeBinding #23201

Closed
CodingOctocat opened this issue Jun 23, 2024 · 2 comments · Fixed by #24688
Closed

ToolbarItem font icon color not updating with AppThemeBinding #23201

CodingOctocat opened this issue Jun 23, 2024 · 2 comments · Fixed by #24688
Labels
area-controls-toolbar ToolBar fixed-in-9.0.0-rc.2.24503.2 p/3 Work that is nice to have platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@CodingOctocat
Copy link

Description

ToolbarItem Icon Color Not Updating with AppThemeBinding

<ToolbarItem Text="Search">
    <ToolbarItem.IconImageSource>
        <FontImageSource FontFamily="SegoeFluentIcons"
                         Glyph="&#xE721;"
                         Color="{AppThemeBinding Light={StaticResource Black},
                                                 Dark={StaticResource White}}" />
    </ToolbarItem.IconImageSource>
</ToolbarItem>

Light mode now:
image

Toggle to dark mode:
image

Steps to Reproduce

No response

Link to public reproduction project repository

No response

Version with bug

8.0.40 SR5

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

Android, I was not able test on other platforms

Affected platform versions

Android API 34

Did you find any workaround?

Use file icon

IconImageSource="{AppThemeBinding Light='search_light.svg',
                                  Dark='search_dark.svg'}"

Relevant log output

No response

@CodingOctocat CodingOctocat added the t/bug Something isn't working label Jun 23, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jun 24, 2024
@Zhanglirong-Winnie
Copy link

This issue can be reproduced on Visual Studio 17.11.0 Preview 2.1 (8.0.40 and 8.0.21).

@CodingOctocat CodingOctocat changed the title ToolbarItem Icon Color Not Updating with AppThemeBinding ToolbarItem font icon color not updating with AppThemeBinding Jun 24, 2024
@PureWeen PureWeen added the p/3 Work that is nice to have label Jun 24, 2024
@PureWeen PureWeen added this to the Backlog milestone Jun 24, 2024
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 3, 2024
@samhouts samhouts added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 10, 2024
StephaneDelcroix added a commit that referenced this issue Sep 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-toolbar ToolBar fixed-in-9.0.0-rc.2.24503.2 p/3 Work that is nice to have platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
5 participants