Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Android device type check and improve UI Test cake scripts #24495

Merged
merged 5 commits into from
Sep 6, 2024

Commits on Aug 28, 2024

  1. Improve Android device type check to use screen size

    For Android visual tests, they should be run with the right
    device image (currently a Nexus 5X API 30). However,
    there's no easy way to check the device type for Appium.
    The check that was there before works on CI
    since the DEVICE_SKIN environment variable is set there
    (set by the android.cake script). And it can work locally if
    folks run android.cake then launch VS from that console
    session to get the env variable - but it doesn't work if VS
    is run separately (normal case).
    
    So update this with a different check. Getting the actual
    Android device type requires using adb. We might eventually
    do that, but for now just use a screen size check as a proxy
    for the device type. Also update the failure message to give
    good instructions.
    BretJohnson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2517305 View commit details
    Browse the repository at this point in the history
  2. Add a "uitest-prepare" target to android.cake

    uitest-prepare will build the test app, launch
    the emulator, and deploy the test app. But
    it won't actually run any tests.
    BretJohnson committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    60d1cf4 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Validate that JAVA_HOME is set

    Also display the Android image name
    BretJohnson committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9fd3c25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c199c14 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    d26219c View commit details
    Browse the repository at this point in the history