Improve Android device type check and improve UI Test cake scripts #24495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Android visual tests, they should be run with the right device image (currently a Nexus 5X API 30). However, there's no easy way to check the device type for Appium. The check that was there before works on CI since the DEVICE_SKIN environment variable is set there (set by the android.cake script). And it can work locally if folks run android.cake then launch VS from that console session to get the env variable - but it doesn't work if VS is run separately (normal case). So update this with a different check. Getting the actual Android device type requires using adb. We might eventually do that, but for now just use a screen size check as a proxy for the device type. Also update the failure message to give good instructions.
uitest-prepare will build the test app, launch the emulator, and deploy the test app. But it won't actually run any tests.
Also display the Android image name
BretJohnson
changed the title
rmarinho
requested review from
PureWeen and
mattleibow
and removed request for
Eilon
BretJohnson
changed the title
BretJohnson
force-pushed
the
dev/bretjohn/validate-android-device-type
branch
from
e0e45b6
to
d26219c
Compare
BretJohnson
changed the title
PureWeen
approved these changes
Sep 5, 2024
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For Android visual tests, they should be run with the right device image. However, there's no easy way to check the device type for Appium. The check that was there before works on CI since the DEVICE_SKIN environment variable is set there (set by the android.cake script). And it can work locally if folks run android.cake then launch VS from that console session to get the env variable - but it doesn't work if VS is run separately (normal case). So update this with a different check, matching on the API level / screen size / screen density capabilities. Also update the failure message to give good instructions.
Also update the android.cake and ios.cake scripts to:
uitest-preparetarget, which creates the image, launches the emulator/simulator, installs the apps, but doesn't run any tests nor does it stop the device when existing, just leaving things running. You can use this script to launch and then run individual tests in VS Test ExplorerIssues Fixed
Fixes #