Update Flyout when Shell.FlyoutContent changes #17359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadapet
added
the
partner/hot-reload-xaml
|
There is still an issue where removing the value of FlyoutContent the first time will not paint the default flyout text until the window is resized. Adding FlyoutContent always works. A different bug would be needed, or there may already be a bug, such as: |
|
Ping @PureWeen for review. I think this change is good even if first removing FlyoutContent on WinUI doesn't render the text. That can be solve separately. |
PureWeen
requested changes
Sep 20, 2023
spadapet
force-pushed
the
dev/peterspa/ShellFlyoutContentChange
branch
from
0346e41
to
ed2a168
Compare
@PureWeen, test added |
PureWeen
approved these changes
Sep 26, 2023
|
/backport to release/8.0.1xx-rc2 |
|
Started backporting to release/8.0.1xx-rc2: https://github.com/dotnet/maui/actions/runs/6628466733 |
|
/backport to release/8.0.1xx-rc2.1 |
|
Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6628705412 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Shell.FlyoutContentallows users to change what the Shell's flyout looks like:If
FlyoutContentchanged at runtime, the UI didn't update (either going to custom content, or reverting back to default content when settingFlyoutContenttonull).The update functionality was already there, like when
IFlyoutView.Flyoutchanged, but that property was also exposed asShell.FlyoutContent.Issues Fixed
Fixes #9080 (Shell.FlyoutContent does not update with hot reload)