Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell.FlyoutContent does not update with hot reload (most likely an SDK issue) #9080

Closed
PureWeen opened this issue Jul 29, 2022 · 5 comments · Fixed by #17359
Closed

Shell.FlyoutContent does not update with hot reload (most likely an SDK issue) #9080

PureWeen opened this issue Jul 29, 2022 · 5 comments · Fixed by #17359
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 p/2 Work that is important, but is currently not scheduled for release partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@PureWeen
Copy link
Member

PureWeen commented Jul 29, 2022

Description

I tested this on WinUI and iOS

If you add Shell.FlyoutContent to replace the FlyoutItems the Flyout doesn't update.

@PureWeen PureWeen added area-controls-shell Shell Navigation, Routes, Tabs, Flyout s/verified Verified / Reproducible Issue ready for Engineering Triage labels Jul 29, 2022
@PureWeen PureWeen added this to the .NET 7 Planning milestone Jul 29, 2022
@jonathanpeppers jonathanpeppers added the partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences label Jan 24, 2023
@samhouts samhouts removed the s/verified Verified / Reproducible Issue ready for Engineering Triage label Apr 5, 2023
@chabiss chabiss added the area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging label Apr 6, 2023
@spadapet spadapet added the p/2 Work that is important, but is currently not scheduled for release label Jul 21, 2023
@samhouts samhouts added the t/bug Something isn't working label Jul 31, 2023
@spadapet spadapet self-assigned this Aug 10, 2023
@spadapet
Copy link
Contributor

Try to repro again

@spadapet
Copy link
Contributor

REPRO:

  1. In Visual Studio, create new MAUI app from blank template
  2. Replace contents in AppShell.xaml with:
<?xml version="1.0" encoding="UTF-8" ?>
<Shell
    x:Name="shell"
    x:Class="MauiApp6.AppShell"
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    xmlns:local="clr-namespace:MauiApp6"
    Shell.FlyoutBehavior="Locked"
    Title="MauiApp6">

    <!--<Shell.FlyoutContent>
        <CollectionView BindingContext="{x:Reference shell}" IsGrouped="True" ItemsSource="{Binding FlyoutItems}">
            <CollectionView.ItemTemplate>
                <DataTemplate>
                    <Label Text="{Binding Title}" TextColor="Red" FontSize="18" />
                </DataTemplate>
            </CollectionView.ItemTemplate>
        </CollectionView>
    </Shell.FlyoutContent>-->

    <FlyoutItem Title='Home Flyout 1'>
        <ShellContent Title="Home 1" ContentTemplate="{DataTemplate local:MainPage}" Route="MainPage1" />
    </FlyoutItem>
    <FlyoutItem Title='Home Flyout 2'>
        <ShellContent Title="Home 2" ContentTemplate="{DataTemplate local:MainPage}" Route="MainPage2" />
    </FlyoutItem>
</Shell>
  1. F5 to build and run on Windows (WinUI)
  2. Ensure XAML hot reload is enabled
  3. Open AppShell.xaml and uncomment the Shell.FlyoutContent

RESULT:
The look of the flyouts doesn't change:

image

EXPECT:
The flyouts should have a new look, like:

image

@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 4, 2023
@Zhanglirong-Winnie
Copy link

Verified this issue with Visual Studio Enterprise 17.8.0 Preview 1.0. Can repro on Windows platform.
Screenshot 2023-09-04 141511

@spadapet
Copy link
Contributor

Note for the fix:
image

@samhouts samhouts modified the milestones: .NET 8 Planning, Under Consideration Sep 13, 2023
@spadapet
Copy link
Contributor

Note to self: Remember to log a new bug that removing the initial value of Shell.FlyoutContent will not render the default flyout labels, only on Windows.

@samhouts samhouts modified the milestones: Under Consideration, .NET 8 GA Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 label Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 p/2 Work that is important, but is currently not scheduled for release partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants