Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/4.0] Fixing tokenizers version #7310

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link

Backport of #7309 to release/4.0

/cc @michaelgsharp

Customer Impact

Testing

Risk

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (1b70381) to head (4578e7a).
Report is 1 commits behind head on release/4.0.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/4.0    #7310   +/-   ##
============================================
  Coverage        68.87%   68.88%           
============================================
  Files             1470     1470           
  Lines           274005   274005           
  Branches         28403    28403           
============================================
+ Hits            188723   188750   +27     
+ Misses           77966    77937   -29     
- Partials          7316     7318    +2     
Flag Coverage Δ
Debug 68.88% <ø> (+<0.01%) ⬆️
production 63.30% <ø> (+0.01%) ⬆️
test 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@michaelgsharp
Copy link
Member

Merging on red since the only test failure is a known unrelated issue and we don't have Build Analysis set up correctly to make it green.

@michaelgsharp michaelgsharp merged commit 972c994 into release/4.0 Nov 14, 2024
22 of 25 checks passed
@michaelgsharp michaelgsharp deleted the backport/pr-7309-to-release/4.0 branch November 14, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants