Fixing tokenizers version #7309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
approved these changes
Nov 13, 2024
| <PropertyGroup> | ||
| <MajorVersion>$([MSBuild]::Subtract($(MajorVersion), 3))</MajorVersion> | ||
| <!-- Blank version for now for API compat --> | ||
| <PackageValidationBaselineVersion></PackageValidationBaselineVersion> |
There was a problem hiding this comment.
You could have this set to 0.22.0 if you want. It should do the right thing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7309 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 1470 1470
Lines 274005 274005
Branches 28403 28403
=======================================
+ Hits 188721 188729 +8
+ Misses 77964 77957 -7
+ Partials 7320 7319 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
tarekgh
approved these changes
Nov 13, 2024
|
Thanks @michaelgsharp for taking care with this issue. |
|
/backport to release/4.0 |
|
Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/11827493749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing tokenizers version.