Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotnet certificate #5794

Merged
merged 3 commits into from
May 18, 2021
Merged

Use dotnet certificate #5794

merged 3 commits into from
May 18, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 12, 2021

@mmitche
Copy link
Member Author

mmitche commented May 12, 2021

@mmitche
Copy link
Member Author

mmitche commented May 12, 2021

I think there is an issue with the msbuild version in use. It may not support the metadata update as expected.

@mmitche
Copy link
Member Author

mmitche commented May 12, 2021

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #5794 (730ce41) into main (43c49f6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5794      +/-   ##
==========================================
- Coverage   68.35%   68.34%   -0.01%     
==========================================
  Files        1131     1131              
  Lines      241210   241204       -6     
  Branches    25039    25039              
==========================================
- Hits       164887   164861      -26     
- Misses      69819    69844      +25     
+ Partials     6504     6499       -5     
Flag Coverage Δ
Debug 68.34% <0.00%> (-0.01%) ⬇️
production 62.96% <ø> (-0.02%) ⬇️
test 89.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs 0.00% <0.00%> (ø)
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0.00%> (-6.99%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 85.74% <0.00%> (-1.14%) ⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs 11.81% <0.00%> (-0.40%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.53% <0.00%> (-0.15%) ⬇️
...oft.ML.Tests/OnnxSequenceTypeWithAttributesTest.cs 94.33% <0.00%> (-0.11%) ⬇️
src/Microsoft.ML.FastTree/FastTreeRanking.cs 54.98% <0.00%> (-0.09%) ⬇️
src/Microsoft.ML.FastTree/FastTree.cs 80.16% <0.00%> (-0.06%) ⬇️
...osoft.ML.OnnxTransformerTest/OnnxTransformTests.cs 95.33% <0.00%> (-0.01%) ⬇️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 95.89% <0.00%> (-0.01%) ⬇️
... and 2 more

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the conflict and it looks good. I'll merge when the tests finish.

@michaelgsharp michaelgsharp merged commit bfda891 into dotnet:main May 18, 2021
darth-vader-lg pushed a commit to darth-vader-lg/ML-NET that referenced this pull request May 19, 2021
* Use dotnet certificate

* Update 3.1 SDK

Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: Michael Sharp <[email protected]>
michaelgsharp added a commit that referenced this pull request May 27, 2021
…#5796)

* Raised the limit of recursions in the creation of the CodedInputStream in the OnnxTransformer (as the default value in the Google.Protobuf). Otherwise some models cannot be loaded (ex. TF2 Efficentdet).

* Updated arcade to the latest version (#5783)

* updated arcade to the latest version

* updated eng/common correctly

* Fixed benchmark test.

* Use dotnet certificate (#5794)

* Use dotnet certificate

* Update 3.1 SDK

Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: Michael Sharp <[email protected]>

* Arm build changes (#5789)

* arm testing

* initial commit with build working on arm64

* windows changes

* build fixes for arm/arm64 with cross compilation

* cross build instructions added

* renamed arm to Arm. Changed TargetArchitecture to default to OS architecture

* fixed some formatting

* fixed capitilization

* fixed Arm Capitilization

* Fix cross-compilation if statement

* building on apple silicon

* removed non build related files

* Changes from PR comments. Removal of FastTreeNative flag.

* Changes from pr comments.

* Fixes from PR comments.

* Changed how we are excluding files.

* Onnx load model (#5782)

* fixed onnx temp model deleting

* random file path fixed

* updates from pr

* Changes from PR comments.

* Changed how auto ml caches.

* PR fixes.

* Update src/Microsoft.ML.AutoML/API/ExperimentSettings.cs

Co-authored-by: Eric Erhardt <[email protected]>

* Tensorflow fixes from PR comments

* fixed filepath issues

Co-authored-by: Eric Erhardt <[email protected]>

Co-authored-by: Michael Sharp <[email protected]>
Co-authored-by: Matt Mitchell <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants