[release/6.0] Remove preview branding #2258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, use an unchanging numerical prerelease label. This produces versions like
6.0.100-1.short_date.revision
for both the package and the AssemblyInformationalVersion. The package version isn't user-facing since it just flows into the SDK, but we wanted the informational version not to say "preview" or "rtm". This also prevents us from having to update the prerelease labels in the future (we have never been very consistent about it in the past).The assembly versions should be unchanged (
6:0:100:0
for the linker, versions like6:0:4:45308
for the MSBuild task and analyzers where the last two components are computed from the date).I noticed that there's another way to remove prerelease labels - you can just not set one, which defines it to be a "release-only" package per Arcade. This produces package versions like
6.0.patch_number
where patch_number is computed from the date/revision - notice it doesn't include the$(PatchVersion)
. I am not sure if it matters, but I went with the current approach so that we can use patch versions to differentiate between versions for servicing purposes.Fixes #2157