Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Remove preview branding #2258

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Sep 4, 2021

As discussed, use an unchanging numerical prerelease label. This produces versions like 6.0.100-1.short_date.revision for both the package and the AssemblyInformationalVersion. The package version isn't user-facing since it just flows into the SDK, but we wanted the informational version not to say "preview" or "rtm". This also prevents us from having to update the prerelease labels in the future (we have never been very consistent about it in the past).

The assembly versions should be unchanged (6:0:100:0 for the linker, versions like 6:0:4:45308 for the MSBuild task and analyzers where the last two components are computed from the date).

I noticed that there's another way to remove prerelease labels - you can just not set one, which defines it to be a "release-only" package per Arcade. This produces package versions like 6.0.patch_number where patch_number is computed from the date/revision - notice it doesn't include the $(PatchVersion). I am not sure if it matters, but I went with the current approach so that we can use patch versions to differentiate between versions for servicing purposes.

Fixes #2157

@sbomer sbomer requested a review from marek-safar as a code owner September 4, 2021 00:56
@sbomer sbomer requested review from agocke and vitek-karas September 4, 2021 00:56
@sbomer sbomer mentioned this pull request Sep 4, 2021
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll take this through with the final RC2 changes we'd like to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants