Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final branding for .NET 6 #2157

Closed
vitek-karas opened this issue Jul 22, 2021 · 0 comments
Closed

Final branding for .NET 6 #2157

vitek-karas opened this issue Jul 22, 2021 · 0 comments
Milestone

Comments

@vitek-karas
Copy link
Member

Update the version of linker to the final RTM version and make sure that change makes it to the RTM branch of SDK.

Related to #2118.

@vitek-karas vitek-karas added this to the .NET 6.0 milestone Jul 22, 2021
agocke pushed a commit that referenced this issue Sep 8, 2021
As discussed, use an unchanging numerical prerelease label. This produces versions like 6.0.100-1.short_date.revision for both the package and the AssemblyInformationalVersion. The package version isn't user-facing since it just flows into the SDK, but we wanted the informational version not to say "preview" or "rtm". This also prevents us from having to update the prerelease labels in the future (we have never been very consistent about it in the past).

The assembly versions should be unchanged (6:0:100:0 for the linker, versions like 6:0:4:45308 for the MSBuild task and analyzers where the last two components are computed from the date).

I noticed that there's another way to remove prerelease labels - you can just not set one, which defines it to be a "release-only" package per Arcade. This produces package versions like 6.0.patch_number where patch_number is computed from the date/revision - notice it doesn't include the $(PatchVersion). I am not sure if it matters, but I went with the current approach so that we can use patch versions to differentiate between versions for servicing purposes.

Fixes #2157
@sbomer sbomer closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants