Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn, nuget/nuget.client #379

Merged
merged 9 commits into from
Apr 9, 2024
Merged

[main] Update dependencies from dotnet/roslyn, nuget/nuget.client #379

merged 9 commits into from
Apr 9, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 18, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 382b0e78-e254-45c6-24d7-08d9158524d7
  • Build: 20240402.15
  • Date Produced: April 3, 2024 1:43:14 AM UTC
  • Commit: cbca41cad4e21c29548e9e57d7135740b6f78df9
  • Branch: refs/heads/release/dev17.10

From https://github.com/nuget/nuget.client

  • Subscription: 6b7d49dd-8422-40b8-3f90-08db15831dbf
  • Build: 6.10.0.97
  • Date Produced: March 26, 2024 6:14:41 PM UTC
  • Commit: fb50d1a45ed10b39b5f335bc3a4bdcaea9b951cf
  • Branch: dev

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build
28b4610 
Microsoft.CodeAnalysis
 From Version 4.9.2-3.24129.6 -> To Version 4.10.0-3.24168.1
@akoeplinger
Copy link
Member

@lambdageek seems this hits a failure

@lambdageek lambdageek self-assigned this Mar 18, 2024
@lambdageek
Copy link
Member

Thanks, I'll take a look. I think roslyn picked up an extra dependency (or a newer dependency) and we might need ot reference that version from the hotreload-utils tooling

@lambdageek
Copy link
Member

@akoeplinger I had to add a dependency on a specific version of Microsoft.Extensions.Logging to match what Roslyn wants.

@akoeplinger
Copy link
Member

hmm this shouldn't be necessary

@lambdageek
Copy link
Member

hmm this shouldn't be necessary

I think it happens somehow because we're being invoked from an MSBuild Exec task which maybe sets DOTNET_ROOT to .dotnet either that or I messed up.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build
f12fe38 
Microsoft.CodeAnalysis
 From Version 4.9.2-3.24129.6 -> To Version 4.10.0-3.24175.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
9a432e9 
…330.2

Microsoft.CodeAnalysis
 From Version 4.9.2-3.24129.6 -> To Version 4.11.0-1.24180.2
@lambdageek
Copy link
Member

@akoeplinger I don't really have better ideas for how to deal with this

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
7315847 
…402.15

Microsoft.CodeAnalysis
 From Version 4.9.2-3.24129.6 -> To Version 4.10.0-3.24202.15
@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
8f9f7fc 
…6.10.0.97

NuGet.Build.Tasks
 From Version 6.10.0-preview.2.81 -> To Version 6.10.0-preview.2.97
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/roslyn [main] Update dependencies from dotnet/roslyn, nuget/nuget.client Apr 8, 2024
@akoeplinger akoeplinger mentioned this pull request Apr 8, 2024
Closed
@akoeplinger
Add temporary reference to Microsoft.Extensions.Logging 8.0.0
f2ed1cb
@akoeplinger
Cleanup dependencies, remove MSBuildLocator
1c3d91a 
MSBuildLocator is no longer needed since dotnet/roslyn#70469 and the workarounds for NuGet.Framework can be removed too.
@akoeplinger
Copy link
Member

I looked into this some more and filed dotnet/roslyn#72938, now that I understand what's going on I'm fine with referencing Microsoft.Extensions.Logging as a temporary workaround.

I also pushed some cleanup.

@dotnet-maestro dotnet-maestro bot merged commit fbe3136 into main Apr 9, 2024
6 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-bef9146b-be83-43f8-bc0c-3626e6aa8022 branch April 9, 2024 21:54
@lambdageek
Copy link
Member

lambdageek commented Apr 9, 2024 •
edited
Loading

@akoeplinger Why was it necessary to remove MSBuildLocator? When hotreload-utils runs to build our tests in dotnet/runtime, I think it helps us to pick the right msbuild instance... Ah nevermind, I see dotnet/roslyn#70469

@lambdageek lambdageek mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@lambdageek lambdageek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoeplinger @lambdageek