Microsoft.CodeAnalysis.Workspaces.MSBuild nuget package is missing reference to Microsoft.Extensions.Logging

[akoeplinger]

Version Used: 4.10.0-3.24202.15

In dotnet/hotreload-utils#379 we hit an exception when upgrading from 4.9 to 4.10 Roslyn:

System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.Logging, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.

File name: 'Microsoft.Extensions.Logging, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
   at Microsoft.CodeAnalysis.MSBuild.DiagnosticReporterLoggerProvider.CreateLoggerFactoryForDiagnosticReporter(DiagnosticReporter reporter)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace..ctor(HostServices hostServices, ImmutableDictionary`2 properties)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.Create(IDictionary`2 properties, HostServices hostServices)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.Create(IDictionary`2 properties)
   at Microsoft.DotNet.HotReload.Utils.Generator.BaselineProject.PrepareMSBuildProject(Config config, EditAndContinueCapabilities capabilities, CancellationToken ct)
   at Microsoft.DotNet.HotReload.Utils.Generator.BaselineProject.Make(Config config, EditAndContinueCapabilities capabilities, CancellationToken ct)
   at Microsoft.DotNet.HotReload.Utils.Generator.Runner.SetupBaseline(EditAndContinueCapabilities capabilities, CancellationToken ct)
   at Microsoft.DotNet.HotReload.Utils.Generator.Runner.Run(CancellationToken ct)

Looking at the .nuspec of Microsoft.CodeAnalysis.Workspaces.MSBuild I saw that it is referencing only Microsoft.Extensions.Logging.Abstractions, but not Microsoft.Extensions.Logging.

The latter assembly is referenced since 19751d7 because LoggerFilterOptions is contained in Microsoft.Extensions.Logging, not .Abstractions:

roslyn/src/Workspaces/Core/MSBuild/MSBuild/DiagnosticReporterLoggerProvider.cs

Line 33 in 70316b7

new LoggerFilterOptions() { MinLevel = LogLevel.Warning });

We presumably need to update the package dependency here:

roslyn/src/Workspaces/Core/MSBuild/Microsoft.CodeAnalysis.Workspaces.MSBuild.csproj

Lines 28 to 30 in 8fffb1b

	<!-- These PackageReferences aren't needed for the compiler for this project, but ensure correct NuGet packaging. Since we're bundling the BuildHost in lib/, we need to
	ensure we include the references it needs, but since it's PrivateAssets="true" they don't flow into this package's package references when packaging. -->
	<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />

/cc @jasonmalinowski @dibarbet

[CyrusNajmabadi]

tagging @JoeRobich as well.

[akoeplinger]

Ping. I can send a PR to fix the nuget reference but I'm not sure depending on the non-abstraction package was intentional.

[dibarbet]

Believe this was fixed by #73393, should be in the 17.11 packages

[akoeplinger]

I can confirm this is fixed in 17.11 packages, thanks