Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test-related scripts #17333

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Simplify test-related scripts #17333

merged 10 commits into from
Jun 27, 2024

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Jun 21, 2024 •
edited
Loading

  • Merge XUnit and NUnit functions because they don't seem to make a difference
  • Remove dead test filter parameter and related logic: it was introduced here and lost relevance here
  • Disable a few compiler service tests failing in .NET Core: before they were just not executed due to script bugs

Related: #13654
Related: #17336

@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

@psfinaki
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki marked this pull request as ready for review June 21, 2024 18:26
@psfinaki psfinaki requested a review from a team as a code owner June 21, 2024 18:26
@psfinaki psfinaki enabled auto-merge (squash) June 21, 2024 18:32
@psfinaki
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

T-Gro
T-Gro reviewed Jun 24, 2024
View reviewed changes
eng/build.sh Show resolved Hide resolved
@psfinaki psfinaki mentioned this pull request Jun 25, 2024
Merged
@psfinaki psfinaki merged commit 43bcb29 into dotnet:main Jun 27, 2024
30 checks passed
@psfinaki psfinaki deleted the testadapters branch June 28, 2024 10:33
This was referenced Jul 25, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments

@KevinRansom KevinRansom KevinRansom approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psfinaki @vzarytovskii @KevinRansom @T-Gro