Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize the number of desktop-only compiler service tests #17336

Open
psfinaki opened this issue Jun 21, 2024 · 4 comments
Open

Minimize the number of desktop-only compiler service tests #17336

psfinaki opened this issue Jun 21, 2024 · 4 comments
Labels
Area-Infrastructure Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone

Comments

@psfinaki
Copy link
Member

We have already a few dozens of compiler service tests marked as FactForDesktop.

While skimming through them, I didn't find a good reason for that in most cases, they should be revisited and either fixed or given a proper explanation on why they are disabled.

@abonie
Copy link
Member

abonie commented Jun 24, 2024

There might not be one common reason for all of these tests other that they don't work on core CLR. It is probably not worth the time investment to look at ~150 tests individually and try to rewrite each of them for core CLR. Most/all of them were migrated from fsharpQA.

@psfinaki
Copy link
Member Author

I don't think there is a common reason yeah. But it might be worth at least visually going through that and analyzing what's especially concerning (like - what really should work on Core CLR).

@vzarytovskii
Copy link
Member

I personally don't think it's worth spending time on it. Not now for sure. Majority of the tests were migrated from desktop suite (fsharpqa or cambridge suites), and likely rely on desktop compiler, bcl and runtime behaviour. To run them everywhere they'll likely need to be duplicated, corrected and verified.

@psfinaki
Copy link
Member Author

FYI I am not talking about those ones, the migrated ones are component tests. Also good to look at but yeah can wait.

I meant those compiler service tests, and it's only about a dozen of them - mostly in ProjectAnalysisTests and newly discovered AssemblyContentProviderTests.

image

@T-Gro T-Gro added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
Status: New
Development

No branches or pull requests

4 participants