incorporate cleanup related to analyzers #11151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready - @TIHan @KevinRansom @vzarytovskii @cartermp can I have an approval? thanks |
TIHan
approved these changes
Feb 26, 2021
This was referenced Mar 3, 2021
Merged
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* incorporate cleanup related to analyzers * fix error regressions Co-authored-by: Don Syme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Replaces #11147)
This extracts out some cleanup from #11057
Remove NumberedError, it is the same as Error
Use FSharpDiagnosticSeverity everywhere instead of a boolean isError flag
Move some things into CompilerImports.fs from fsc.fs which gives better layering
Make parsing always return a ParsedInput rather than a ParsedInput option, creating an empty ParsedInput in the (very rare) cases where parsing outright failed. This makes subsequent processing much simpler
Move FSharpProjectOptions into FSharpCheckerResults.fs/fsi. THis is a better location as it means the FSharpCheckerResults can report the options as part of the project context