Cleanup related to diagnostics, ParsedInput #11147
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts out some cleanup from #11057
Remove NumberedError, it is the same as Error
Use FSharpDiagnosticSeverity everywhere instead of a boolean isError flag
Move some things into CompilerImports.fs from fsc.fs which gives better layering
Make parsing always return a ParsedInput rather than a ParsedInput option, creating an empty ParsedInput in the (very rare) cases where parsing outright failed. This makes subsequent processing much simpler
Move FSharpProjectOptions into FSharpCheckerResults.fs/fsi. THis is a better location as it means the FSharpCheckerResults can report the options as part of the project context