Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate version calculations from release/16.9 #10479

Merged
merged 1 commit into from
Nov 17, 2020
Merged

migrate version calculations from release/16.9 #10479

merged 1 commit into from
Nov 17, 2020

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Nov 16, 2020

This migrates the changes made in #10221 and #10249 to main and supersedes #10468.

The end result is that running .\eng\MockBuild.ps1 resulted in the following:

  • FSharp.Core.5.0.1.nupkg
    • FSharp.Core.dll:
      • AssemblyVersion = 5.0.0.0
      • AssemblyFileVersion = 5.0.120.56600 (calculated by Arcade)
      • AssemblyInformationalVersion = 5.0.1-beta.20566.0+###### (calculated by Arcade where ###### is the SHA)
  • Microsoft.FSharp.Compiler.11.0.1.nupkg
    • fsc.exe:
      • AssemblyVersion = 11.0.1.0
      • AssemblyFileVersion = 11.0.120.56600 (calculated by Arcade)
      • AssemblyInformationalVersion = 11.0.1-beta.20566.0+###### (calculated by Arcade where ###### is the SHA)

@brettfo brettfo requested a review from KevinRansom November 16, 2020 22:58
@brettfo brettfo mentioned this pull request Nov 16, 2020
Closed
KevinRansom
KevinRansom approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brettfo brettfo merged commit ca464f8 into dotnet:main Nov 17, 2020
@brettfo brettfo deleted the version-calc branch November 17, 2020 00:42
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@brettfo @nosami
migrate version calculations from release/16.9 (dotnet#10479)
04cd4ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettfo @KevinRansom