[16.9] use proper assembly and package versions for FSharp.Core #10249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
binding-redirect
branch
5 times, most recently
from
9484086 to
c3e230f
Compare
brettfo
changed the title
brettfo
force-pushed
the
binding-redirect
branch
2 times, most recently
from
70a199a to
76443a7
Compare
brettfo
force-pushed
the
binding-redirect
branch
from
76443a7 to
15f9060
Compare
brettfo
changed the title
TIHan
approved these changes
Oct 14, 2020
cartermp
approved these changes
Oct 15, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…et#10249) * add PR build to mock official build * fix assembly and package versions * improve build error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent version number refactor is failing internal builds due to how we calculate those. The bug manifests itself when creating binding redirects and was rather tricky to track down, but the real issue is that we want to maintain assembly version
5.0.0.0onFSharp.Corebut update the NuGet package version to5.0.1.I've also added another CI step to fake an internal build with a build ID to mimic the way this failed in the signed build.
PR is draft until a full internal build passes.Internal build is good.