Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add "opens" for parent namespaces to tc environments #10386

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Don't add "opens" for parent namespaces to tc environments #10386

merged 6 commits into from
Nov 4, 2020

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Nov 3, 2020 •
edited
Loading

Fixes #10385.

@auduchinok auduchinok changed the title Don't add "opens" for parens namespaces to tc environments Don't add "opens" for parent namespaces to tc environments Nov 3, 2020
@auduchinok
Copy link
Member Author

auduchinok commented Nov 3, 2020 •
edited
Loading

OK, this approach seems to break some other things. I'm looking into it.

@auduchinok
Copy link
Member Author

auduchinok commented Nov 3, 2020 •
edited
Loading

This is ready for review.

cartermp
cartermp approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vzarytovskii vzarytovskii merged commit 153b27f into dotnet:main Nov 4, 2020
@auduchinok auduchinok deleted the tcEnv-parentNs branch November 4, 2020 17:16
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@auduchinok @nosami
Don't add "opens" for parent namespaces to tc environments (dotnet#10386
efdef78 
)

* Don't add "opens" for parens namespaces to tc environments

* Revert sorted opens change

* Better parameter name

* Add test

* Update parameter name in signature

* Add another test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FSharpType.Format drops qualifier namespaces that are parent in the context
3 participants
@auduchinok @vzarytovskii @cartermp