Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharpType.Format drops qualifier namespaces that are parent in the context #10385

Closed
auduchinok opened this issue Nov 3, 2020 · 0 comments · Fixed by #10386
Closed

FSharpType.Format drops qualifier namespaces that are parent in the context #10385

auduchinok opened this issue Nov 3, 2020 · 0 comments · Fixed by #10386
Labels
Milestone

Comments

@auduchinok
Copy link
Member

auduchinok commented Nov 3, 2020

FSharpType.Format drops parent namespaces when the type being formatted and context have a common parent namespace.

namespace Ns1.Ns2

type T() = class end

Formatting T via FSharpType.Format in Ns1.Ns3 context:

Expected:

namespace Ns1.Ns3

Ns1.Ns2.T

Actual:

namespace Ns1.Ns3

Ns2.T // produces error

It should only skip qualifier namespaces when they are actually opened or are the same namespace as the context.

In addition to FSharpType.Format usages in tooling, it likely affects generating things in the compiler, e.g. signature files generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants