Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List<T> as inline collections implementation. #33476

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

cincuranet
Copy link
Contributor

Explicitly handling only what implements IList<T> (per #32413 (comment)).

The tests are exercising also code path for #33466.

Fixes #32413

@cincuranet cincuranet requested a review from a team April 4, 2024 12:24
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see mainly proposal to keep a single ShouldConvert overload here.

@cincuranet cincuranet requested a review from roji April 5, 2024 15:11
@cincuranet cincuranet merged commit ee68d71 into dotnet:main Apr 5, 2024
5 of 7 checks passed
@cincuranet cincuranet deleted the issue-32413 branch April 5, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support inline List (and other non-array) collections as inline collection query roots
2 participants