Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix funcletizer for VisitListInit #33466

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix funcletizer for VisitListInit #33466

merged 1 commit into from
Apr 3, 2024

Conversation

cincuranet
Copy link
Contributor

Fixes initialization of visitedInitializersArguments in VisitListInit. We need to fill complete array - not only up to i because next iteration will access visitedInitializersArguments (on next index).

@cincuranet cincuranet requested a review from a team April 3, 2024 09:42
roji
roji approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but add a regression test?

@cincuranet
Copy link
Contributor Author

Yes, forgot to mention. I'll add test later, together with work for #32413, because it shares the underlying code path.

@cincuranet cincuranet merged commit 0fc310f into dotnet:main Apr 3, 2024
7 checks passed
@cincuranet cincuranet deleted the fix-funcletizer branch April 3, 2024 10:21
@cincuranet cincuranet mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cincuranet @roji