Prune SQL Server OPENJSON's WITH clause #32673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Dec 25, 2023
| [OwnedCollectionBranch] nvarchar(max) '$.OwnedCollectionBranch' AS JSON, | ||
| [OwnedReferenceBranch] nvarchar(max) '$.OwnedReferenceBranch' AS JSON | ||
| ) AS [o] | ||
| FROM OPENJSON([j].[OwnedCollectionRoot], '$') WITH ([OwnedCollectionBranch] nvarchar(max) '$.OwnedCollectionBranch' AS JSON) AS [o] |
There was a problem hiding this comment.
This is a nice example: the 2nd OPENJSON down below gets its WITH clause completely trimmed away, because it's only used for COUNT(*). But its argument referenced [o].[OwnedCollectionBranch], which makes it get preserved here on the 1st OPENJSON, as the only one.
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Microsoft.EntityFrameworkCore.Query.SqlExpressions; | ||
| using ColumnInfo = Microsoft.EntityFrameworkCore.SqlServer.Query.Internal.SqlServerOpenJsonExpression.ColumnInfo; |
There was a problem hiding this comment.
I can inline and qualify with SqlServerOpenJsonExpression.ColumnInfos if you think that's better..
AndriySvyryd
approved these changes
Dec 30, 2023
roji
force-pushed
the
PruneOpenJson
branch
3 times, most recently
from
c683714
to
2992a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the new pruner (#32672,
review 2nd commit only) to prune the WITH column list on OPENJSON expressions.Closes #32668