Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune OPENJSON columns list #32668

Closed
Tracked by #31327
roji opened this issue Dec 25, 2023 · 0 comments · Fixed by #32673
Closed
Tracked by #31327

Prune OPENJSON columns list #32668

roji opened this issue Dec 25, 2023 · 0 comments · Fixed by #32673
Assignees
@roji
Labels
area-query area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@roji
Copy link
Member

roji commented Dec 25, 2023

When we generate OPENJSON with WITH, we specify the column list in the WITH clause for all columns we know exist, based on the model. If some of these columns aren't referenced, prune them.

Depends on making pruning a real visitor and exposing it publicly (to providers), related to #31083.
@roji roji self-assigned this Dec 25, 2023
roji added a commit to roji/efcore that referenced this issue Dec 25, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
eeccaa9 
Closes dotnet#32668
roji added a commit to roji/efcore that referenced this issue Dec 25, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
216c83e 
Closes dotnet#32668
@roji roji mentioned this issue Dec 25, 2023
Merged
roji added a commit to roji/efcore that referenced this issue Dec 25, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
a327a62 
Closes dotnet#32668
@roji roji mentioned this issue Dec 25, 2023
Merged
@roji roji added this to the 9.0.0 milestone Dec 25, 2023
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 25, 2023
roji added a commit to roji/efcore that referenced this issue Dec 29, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
cd06d94 
Closes dotnet#32668
roji added a commit to roji/efcore that referenced this issue Dec 30, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
ff1a3fc 
Closes dotnet#32668
roji added a commit to roji/efcore that referenced this issue Dec 30, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
c683714 
Closes dotnet#32668
roji added a commit to roji/efcore that referenced this issue Dec 30, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
2992a49 
Closes dotnet#32668
roji added a commit to roji/efcore that referenced this issue Dec 30, 2023
@roji
Prune SQL Server OPENJSON's WITH clause
8fe2e0f 
Closes dotnet#32668
roji added a commit that referenced this issue Dec 30, 2023
@roji
Prune SQL Server OPENJSON's WITH clause (#32673)
2e7ea62 
Closes #32668
@roji roji mentioned this issue Jan 15, 2024
Closed
8 tasks
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
@roji roji mentioned this issue Feb 11, 2024
Closed
@roji roji mentioned this issue Sep 23, 2024
Closed
@roji roji modified the milestones: 9.0.0-preview1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-query area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Prune SQL Server OPENJSON's WITH clause roji/efcore
2 participants
@ajcvickers @roji