Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of JSON primitive collection serialization #31272

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Part of JSON primitive collection serialization #31272

merged 4 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. Part of JSON primitive collection serialization 

    Part of #30677

There is still work to do here, but this is basically working so I wanted to get it out for review.

Remaining work:
- Negative cases/exception messages
- Re-introduce checks for whether or not query supports primitive collections
- Cases where the primitive collection object exists and should be added to
- Custom element type mapping on the property
- Custom element reader/writer
- Custom collection reader/writer
- Use default element type mapping configured in ConfigureConventions
- Update Cosmos primitive collection mapping
- More query tests!
    @ajcvickers
    ajcvickers committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    6b44512 View commit details
    Browse the repository at this point in the history

  2. Uses existing JSON primitive collection instead of creating a new one 

    Part of #30677

Builds on #31272

This is the case where the CLR types contains, for example, an `ObservableCollection<int>`. In this case, we populate this existing collection, rather than creating a new instance.

Same still needs to be done for relational materialization of primitive collections.
    @ajcvickers
    ajcvickers committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    376263c View commit details
    Browse the repository at this point in the history

  3. Added using existing collection for primitive collections not inside … 

    …a JSON doc
    @ajcvickers
    ajcvickers committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    87c8e18 View commit details
    Browse the repository at this point in the history

  4. Review feedback

    @ajcvickers
    ajcvickers committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    477d819 View commit details
    Browse the repository at this point in the history