Part of JSON primitive collection serialization #31272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
commented
Jul 15, 2023
test/EFCore.SqlServer.FunctionalTests/Query/NonSharedPrimitiveCollectionsQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
ajcvickers
commented
Jul 15, 2023
test/EFCore.Sqlite.FunctionalTests/Query/NonSharedPrimitiveCollectionsQuerySqliteTest.cs
Show resolved
Hide resolved
maumar
reviewed
Jul 17, 2023
maumar
reviewed
Jul 17, 2023
maumar
reviewed
Jul 17, 2023
...l/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
Show resolved
Hide resolved
|
shaper changes look good! |
|
@roji Any thoughts on this? I've got the next part ready to go. |
This was referenced Jul 17, 2023
src/EFCore.SqlServer/Query/Internal/SqlServerQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
roji
reviewed
Jul 18, 2023
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
...l/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
Show resolved
Hide resolved
...l/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/JsonTypesSqlServerTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/NonSharedPrimitiveCollectionsQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/NonSharedPrimitiveCollectionsQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/PrimitiveCollectionsQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.Sqlite.FunctionalTests/Query/NonSharedPrimitiveCollectionsQuerySqliteTest.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jul 18, 2023
AndriySvyryd
approved these changes
Jul 18, 2023
Part of #30677 There is still work to do here, but this is basically working so I wanted to get it out for review. Remaining work: - Negative cases/exception messages - Re-introduce checks for whether or not query supports primitive collections - Cases where the primitive collection object exists and should be added to - Custom element type mapping on the property - Custom element reader/writer - Custom collection reader/writer - Use default element type mapping configured in ConfigureConventions - Update Cosmos primitive collection mapping - More query tests!
ajcvickers
force-pushed
the
230711HangInThereJson
branch
from
fef7cb8
to
477d819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #30677
There is still work to do here, but this is basically working so I wanted to get it out for review.
Remaining work:
Cases where the primitive collection object exists and should be added toUses existing JSON primitive collection instead of creating a new one #31282