Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lazy-loading to be configured per navigation #29943

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

ajcvickers
Copy link
Contributor

Part of #10787

Also fixes two issues with service properties and their delegates:

  • The delegate is now always created pointing to the instance of the service property stored in the entity. Previously, it could sometimes be a delegate pointing to a new service instance.
  • The service property instance is always treated as an IInjectableService when attaching or materializing, so the metadata is always present on the instance.

@ajcvickers ajcvickers requested a review from a team December 29, 2022 12:58
Part of #10787

Also fixes two issues with service properties and their delegates:

- The delegate is now always created pointing to the instance of the service property stored in the entity. Previously, it could sometimes be a delegate pointing to a new service instance.
- The service property instance is always treated as an IInjectableService when attaching or materializing, so the metadata is always present on the instance.
@ajcvickers ajcvickers force-pushed the BackToBedBackToReality1226 branch from 5e68b4e to d67cf1d Compare December 31, 2022 11:19
@ajcvickers ajcvickers merged commit 38f69c6 into main Dec 31, 2022
@ajcvickers ajcvickers deleted the BackToBedBackToReality1226 branch December 31, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants