Skip to content

Commit

Permalink
Review updates.
Browse files Browse the repository at this point in the history
  • Loading branch information
ajcvickers committed Dec 31, 2022
1 parent 991df28 commit d67cf1d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/EFCore/Infrastructure/AccessorExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public static TService GetService<TService>(this IInfrastructure<IServiceProvide
/// <returns>The requested service.</returns>
[DebuggerStepThrough]
public static object GetService(this IInfrastructure<IServiceProvider> accessor, Type serviceType)
=> InfrastructureExtensions.GetService(serviceType, accessor);
=> InfrastructureExtensions.GetService(accessor, serviceType);

/// <summary>
/// <para>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ public static class InfrastructureExtensions
/// </summary>
public static TService GetService<TService>(IInfrastructure<IServiceProvider> accessor)
where TService : class
=> (TService)GetService(typeof(TService), accessor);
=> (TService)GetService(accessor, typeof(TService));

/// <summary>
/// This is an internal API that supports the Entity Framework Core infrastructure and not subject to
/// the same compatibility standards as public APIs. It may be changed or removed without notice in
/// any release. You should only use it directly in your code with extreme caution and knowing that
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
public static object GetService(Type serviceType, IInfrastructure<IServiceProvider> accessor)
public static object GetService(IInfrastructure<IServiceProvider> accessor, Type serviceType)
{
var internalServiceProvider = accessor.Instance;

Expand Down
1 change: 0 additions & 1 deletion src/EFCore/Metadata/IReadOnlyNavigationBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ bool LazyLoadingEnabled
=> (bool?)this[CoreAnnotationNames.LazyLoadingEnabled] ?? true;

/// <inheritdoc />
// TODO: Remove when #3864 is implemented
bool IReadOnlyPropertyBase.IsShadowProperty()
=> this.GetIdentifyingMemberInfo() == null;
}

0 comments on commit d67cf1d

Please sign in to comment.