Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to .NET 7 preview #27422

Closed
wants to merge 2 commits into from
Closed

Update to .NET 7 preview #27422

wants to merge 2 commits into from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 10, 2022 •
edited
Loading

@Youssef1313 Youssef1313 marked this pull request as ready for review February 10, 2022 08:14
@roji
Copy link
Member

roji commented Feb 10, 2022

@Youssef1313 thanks for this PR - we generally prefer to not be on a daily build SDK, since that makes it more difficult for users to test our own e.g. previews (we typically update SDKs with each preview, at least in the beginning of the release.

Is it right to assume that dotnet/roslyn-analyzers#5828 will be closed by the time preview2 is released? If so, we can probably ignore this altogether (as we won't be using the in-between daily build SDKs). Otherwise we can just temporarily remove the target-typed new in this particular case, without bumping the SDK.

@Youssef1313
Copy link
Member Author

I have no idea of dotnet/roslyn-analyzers#5828 will be fixed soon. There is a PR already dotnet/roslyn-analyzers#5831

@sharwell Any chance for your PR to be merged soon?

Meanwhile, I'll close this PR.

@Youssef1313 Youssef1313 deleted the patch-1 branch February 10, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youssef1313 @roji