Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to create compiled models #24906

Merged
1 commit merged into from
May 18, 2021
Merged

Add commands to create compiled models #24906

1 commit merged into from
May 18, 2021

Conversation

AndriySvyryd
Copy link
Member

Warn when using and old model
Enable NRT-enabled code generation
Remove the need to call FinalizeModel before UseModel
Split out the boilerplate part of the compiled model

Fixes #1906

@AndriySvyryd
Copy link
Member Author

Ping. We branch for preview5 tomorrow.

Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3rd commit here which has title "Add commands to create compiled..."

Base automatically changed from Issue1906 to main May 18, 2021 04:32
Warn when using and old model
Enable NRT-enabled code generation
Remove the need to call FinalizeModel before UseModel
Split out the boilerplate part of the compiled model

Fixes #1906
@AndriySvyryd
Copy link
Member Author

@smitpatel Much appreciated. Forgot to rebase.

@ghost
Copy link

ghost commented May 18, 2021

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented May 18, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 5540433 into main May 18, 2021
@ghost ghost deleted the Issue1906_2 branch May 18, 2021 05:13
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce EF Core application startup time via compiled models
3 participants