Add a compiled slim model generator #24612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Apr 9, 2021
|
@dotnet/efteam This is now ready for a full review |
|
Ping. We branch for preview5 tomorrow. |
smitpatel
reviewed
May 18, 2021
src/EFCore.InMemory/Design/Internal/InMemoryCSharpSlimAnnotationCodeGenerator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 18, 2021
smitpatel
reviewed
May 18, 2021
src/EFCore.SqlServer/Design/Internal/SqlServerCSharpRuntimeAnnotationCodeGenerator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 18, 2021
src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs
Show resolved
Hide resolved
smitpatel
approved these changes
May 18, 2021
Remove more design-time metadata from runtime model Fix some configuration loss when reattaching entity types Add missing SqlServer Metadata methods Add more tests
|
How much breaking changes rule applies to generated code here? Can we change the generated code in future release in breaking way (i.e. code generated earlier wouldn't compile without regenerating). This differs bit from migrations where old migrations need to continue working. |
|
@smitpatel The compiled models need to be regenerated on every major or minor version upgrade. #24906 adds a warning for this. |
|
However users might have code in partial classes using the same API, so the general breaking changes policy applies to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1906
The indexer properties now require a setter
The DbFunction names are now more readable if generic types are involved
Add designTime parameter to IRelationalAnnotationProvider
Remove more design-time metadata from runtime model
Fix some configuration loss when reattaching entity types
Add missing SqlServer Metadata methods