Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote FROM table identifier when rewriting #23585

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Quote FROM table identifier when rewriting #23585

merged 1 commit into from
Dec 8, 2020

Conversation

CaringDev
Copy link
Contributor

fixes invalid migrations when the table name is a reserved keyword (e.g. 'Group')

@CaringDev CaringDev marked this pull request as draft December 4, 2020 14:41
@CaringDev
Copy link
Contributor Author

CaringDev commented Dec 4, 2020 •
edited
Loading

I'll fix the tests too... after the weekend 🤯 Going for a run now 🏃‍♂️ nope, stuck to the keyboard... I am... it seems 😆

@CaringDev CaringDev marked this pull request as ready for review December 4, 2020 15:50
@ajcvickers ajcvickers requested a review from bricelam December 4, 2020 19:02
@CaringDev
Quote FROM table identifier when rewriting
68bbf70 
fixes invalid migrations when the table name is a reserved keyword (e.g. 'Group')
@CaringDev
Copy link
Contributor Author

please excuse me for the repeated late force-pushes... I squashed and thought GH did not pick it up... all OK now.

@bricelam bricelam assigned bricelam and unassigned smitpatel Dec 8, 2020
bricelam
bricelam approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bricelam bricelam merged commit ff9d16e into dotnet:main Dec 8, 2020
@bricelam bricelam mentioned this pull request Dec 8, 2020
Closed
@CaringDev CaringDev deleted the patch-1 branch December 8, 2020 19:22
@ajcvickers ajcvickers mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees

@bricelam bricelam

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaringDev @bricelam @ajcvickers @smitpatel