Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Migrations: Missing table name quotes during rebuild #23621

Closed
bricelam opened this issue Dec 8, 2020 · 0 comments
Closed

SQLite Migrations: Missing table name quotes during rebuild #23621

bricelam opened this issue Dec 8, 2020 · 0 comments
Assignees
Labels
area-migrations area-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported Servicing-approved type-bug
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Dec 8, 2020

(Originally reported by @CaringDev in PR #23585)

When rebuilding tables, we fail to quote the table name in the INSERT..FROM statement:

INSERT INTO "ef_temp_Group" ("Id", "Name")
SELECT "Id", "Name"
FROM Group; -- <<< Missing quotes!

This can result in syntax errors:

SQLite Error 1: 'near "Group": syntax error'.

@bricelam bricelam added type-bug closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported area-migrations area-sqlite labels Dec 8, 2020
@bricelam bricelam self-assigned this Dec 8, 2020
@bricelam bricelam added this to the 5.0.2 milestone Dec 8, 2020
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migrations area-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported Servicing-approved type-bug
Projects
None yet
Development

No branches or pull requests

3 participants