Cleanup and add documentation for IndentedStringBuilder #20530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Apr 5, 2020
src/EFCore.Relational/Migrations/MigrationCommandListBuilder.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 5, 2020
Fixes #20383 Looked at making it pubternal or internal again, but it seems to be fundamental to the C# code generators in the design assembly. Considered moving it to design, but that would result in duplicate internal code other places. So just documented and cleaned up the surface--in particular, it only handles strings so that any possible locale-specific string conversions are forced to happen outside.
ajcvickers
force-pushed
the
IndentYourselfClean0404
branch
from
6092c99
to
3510498
Compare
AndriySvyryd
approved these changes
Apr 6, 2020
|
When syncing EFCore.PG, it's somewhat annoying to have to do ToString on every integer I need to render in SQL... Is there any reason here to be more restrictive than standard StringBuilder, which does accept object (and does ToString)? It doesn't seem like that much of a pit of failure to me... |
|
If we really don't want object, we could at least have some overloads for common types such as int. |
|
(turned out not to happen that much in my codebase, though) |
roji
added a commit
to roji/efcore.pg
that referenced
this pull request
Apr 15, 2020
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20383
Looked at making it pubternal or internal again, but it seems to be fundamental to the C# code generators in the design assembly. Considered moving it to design, but that would result in duplicate internal code other places. So just documented and cleaned up the surface--in particular, it only handles strings so that any possible locale-specific string conversions are forced to happen outside.