Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndentedStringBuilder is internal #20383

Closed
smitpatel opened this issue Mar 23, 2020 · 2 comments · Fixed by #20530
Closed

IndentedStringBuilder is internal #20383

smitpatel opened this issue Mar 23, 2020 · 2 comments · Fixed by #20530
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

Used in Migrator to construct SQL.
@smitpatel
Copy link
Member Author

Also in RelationalCommandBuilder

@ajcvickers ajcvickers self-assigned this Mar 27, 2020
@ajcvickers ajcvickers mentioned this issue Mar 27, 2020
Closed
@smitpatel
Copy link
Member Author

It is public now and being used in public APIs in migration code generation.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 27, 2020
ajcvickers added a commit that referenced this issue Apr 4, 2020
@ajcvickers
Cleanup and add documentation for IndentedStringBuilder
6092c99 
Fixes #20383

Looked at making it pubternal or internal again, but it seems to be fundamental to the C# code generators in the design assembly. Considered moving it to design, but that would result in duplicate internal code other places. So just documented and cleaned up the surface--in particular, it only handles strings so that any possible locale-specific string conversions are forced to happen outside.
@ajcvickers ajcvickers mentioned this issue Apr 4, 2020
Merged
@ajcvickers ajcvickers added providers-beware closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Apr 4, 2020
ajcvickers added a commit that referenced this issue Apr 5, 2020
@ajcvickers
Cleanup and add documentation for IndentedStringBuilder
3510498 
Fixes #20383

Looked at making it pubternal or internal again, but it seems to be fundamental to the C# code generators in the design assembly. Considered moving it to design, but that would result in duplicate internal code other places. So just documented and cleaned up the surface--in particular, it only handles strings so that any possible locale-specific string conversions are forced to happen outside.
ajcvickers added a commit that referenced this issue Apr 7, 2020
@ajcvickers
Cleanup and add documentation for IndentedStringBuilder
bdaeee1 
Fixes #20383

Looked at making it pubternal or internal again, but it seems to be fundamental to the C# code generators in the design assembly. Considered moving it to design, but that would result in duplicate internal code other places. So just documented and cleaned up the surface--in particular, it only handles strings so that any possible locale-specific string conversions are forced to happen outside.
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Cleanup and add documentation for IndentedStringBuilder dotnet/efcore
2 participants
@ajcvickers @smitpatel