Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fluent API to specify a ValueComparer for a property #18643

Closed
AndriySvyryd opened this issue Oct 29, 2019 · 1 comment · Fixed by #22074
Closed

Add Fluent API to specify a ValueComparer for a property #18643

AndriySvyryd opened this issue Oct 29, 2019 · 1 comment · Fixed by #22074
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

Possibly an overload of HasConversion
@ajcvickers ajcvickers added this to the Backlog milestone Nov 1, 2019
@ajcvickers ajcvickers self-assigned this Nov 1, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 20, 2019
@ajcvickers ajcvickers mentioned this issue Dec 9, 2019
Closed
@ajcvickers
Copy link
Member

Note: consider whether to set all three types of comparer (key, structural, normal) to the same thing by default, and whether or not to do fallback at runtime or by setting multiple by default. See #19256.

@ajcvickers ajcvickers mentioned this issue Jan 2, 2020
Open
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers changed the title Add Fluent API do specify a ValueComparer for a property Add Fluent API to specify a ValueComparer for a property Aug 14, 2020
ajcvickers added a commit that referenced this issue Aug 14, 2020
@ajcvickers
Add overloads to HasConversion that take a ValueComparer
3910b62 
Fixes #18643
@ajcvickers ajcvickers mentioned this issue Aug 14, 2020
Merged
ajcvickers added a commit that referenced this issue Aug 15, 2020
@ajcvickers
Add overloads to HasConversion that take a ValueComparer (#22074)
1dc1788 
Fixes #18643
@ajcvickers ajcvickers mentioned this issue Sep 9, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add overloads to HasConversion that take a ValueComparer dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd