Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fluent API for configuring value snapshot/comparison #10961

Closed
ajcvickers opened this issue Feb 14, 2018 · 2 comments
Closed

Add fluent API for configuring value snapshot/comparison #10961

ajcvickers opened this issue Feb 14, 2018 · 2 comments
Labels
closed-duplicate

Comments

@ajcvickers
Copy link
Member

#9753 added support for DetectChanges to work with types that need a custom snapshot and/or equality comparison. This allows providers (e.g. for Postgres) to create type mappings with these things specified. This issue is about adding fluent API to make it easy for applications to specify equality/snapshot, which is important when using value conversions for model types that need such things.
ajcvickers added a commit that referenced this issue Feb 14, 2018
@ajcvickers
Support change tracking of non-primitive types
68be8f2 
Issue #9753

This is primarily focused at allowing providers to generate type mappings for non-primitive type mappings. It can also be used for non-primitive types that are used through value conversions, but #10961 covers adding fluent API for this. Also, this implementation does not attempt to address perf issues, but I added at note to #9422.

I'm not happy with the name ValueComparer--we should discuss in API review.
@ajcvickers ajcvickers mentioned this issue Feb 14, 2018
Merged
ajcvickers added a commit that referenced this issue Feb 16, 2018
@ajcvickers
Support change tracking of non-primitive types
dd0f846 
Issue #9753

This is primarily focused at allowing providers to generate type mappings for non-primitive type mappings. It can also be used for non-primitive types that are used through value conversions, but #10961 covers adding fluent API for this. Also, this implementation does not attempt to address perf issues, but I added at note to #9422.

I'm not happy with the name ValueComparer--we should discuss in API review.
@ajcvickers ajcvickers added this to the Backlog milestone Feb 16, 2018
@AndriySvyryd
Copy link
Member

Is this fixed by 1dc1788?

@ajcvickers
Copy link
Member Author

Duplicate of #18643

@ajcvickers ajcvickers marked this as a duplicate of #18643 Sep 9, 2020
@ajcvickers ajcvickers removed this from the Backlog milestone Sep 9, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd